Skip to content

Comments

meta: move generators#616

Merged
avivkeller merged 2 commits intomainfrom
meta/move-generators
Feb 21, 2026
Merged

meta: move generators#616
avivkeller merged 2 commits intomainfrom
meta/move-generators

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Feb 19, 2026

This PR moves the generator strategy from lazy load + loading all at entry, to simply having the metadata be synchronous and always exposed and the actual generator implementation to be within a new file of generator.mjs for each generator. This reduces a bit asynchronous overload, separates schema from implementation and also ensures that generator dependencies and code gets initialized only when needed, which solves for now the downstream nodejs/node build.

Copilot AI review requested due to automatic review settings February 19, 2026 16:02
@ovflowd ovflowd requested a review from a team as a code owner February 19, 2026 16:02
@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Feb 20, 2026 8:50pm

Request Review

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 25.08039% with 932 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.46%. Comparing base (32a824c) to head (5722d1a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/generators/legacy-html/generate.mjs 0.00% 142 Missing ⚠️
src/generators/man-page/generate.mjs 0.00% 84 Missing ⚠️
src/generators/addon-verify/generate.mjs 0.00% 81 Missing ⚠️
src/generators/legacy-json-all/generate.mjs 0.00% 80 Missing ⚠️
src/generators/legacy-html-all/generate.mjs 0.00% 74 Missing ⚠️
src/generators/jsx-ast/generate.mjs 0.00% 67 Missing ⚠️
src/generators/legacy-json/generate.mjs 0.00% 66 Missing ⚠️
src/generators/sitemap/generate.mjs 0.00% 64 Missing ⚠️
src/generators/orama-db/generate.mjs 0.00% 59 Missing ⚠️
src/generators/ast/generate.mjs 0.00% 58 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
- Coverage   78.62%   72.46%   -6.17%     
==========================================
  Files         128      144      +16     
  Lines       12461    12600     +139     
  Branches      902      872      -30     
==========================================
- Hits         9798     9131     -667     
- Misses       2658     3464     +806     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

orama-db Generator

File Base Head Diff
orama-db.json 8.03 MB 8.03 MB +2.00 B (+0.00%)

web Generator

File Base Head Diff
styles.css 128.14 KB 128.21 KB +67.00 B (+0.05%)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ovflowd
Copy link
Member Author

ovflowd commented Feb 19, 2026

@avivkeller just do whatever with the PR, I don't have the time/mental availability to address your nitpicks now.

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=

@ovflowd
Copy link
Member Author

ovflowd commented Feb 20, 2026

=

= ?

@ovflowd
Copy link
Member Author

ovflowd commented Feb 20, 2026

=

image

@avivkeller avivkeller merged commit cc593c5 into main Feb 21, 2026
20 checks passed
@avivkeller avivkeller deleted the meta/move-generators branch February 21, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants